[DAG] Improve Aliasing of operations to static alloca
authorNirav Dave <niravd@google.com>
Mon, 10 Jul 2017 15:39:41 +0000 (15:39 +0000)
committerNirav Dave <niravd@google.com>
Mon, 10 Jul 2017 15:39:41 +0000 (15:39 +0000)
commit163e1ad9dcfe6113ddf0cc8d73976dfc5db17ebe
tree25f67898c4cbac749b00a0485aca16cb5f5658d4
parent7cd7c1a7b50abcc729ddffa0e5654c343e7b03f7
[DAG] Improve Aliasing of operations to static alloca

Memory accesses offset from frame indices may alias, e.g., we
may merge write from function arguments passed on the stack when they
are contiguous. As a result, when checking aliasing, we consider the
underlying frame index's offset from the stack pointer.

Static allocs are realized as stack objects in SelectionDAG, but its
offset is not set until post-DAG causing DAGCombiner's alias check to
consider access to static allocas to frequently alias. Modify isAlias
to consider access between static allocas and access from other frame
objects to be considered aliasing.

Many test changes are included here. Most are fixes for tests which
indirectly relied on our aliasing ability and needed to be modified to
preserve their original intent.

The remaining tests have minor improvements due to relaxed
ordering. The exception is CodeGen/X86/2011-10-19-widen_vselect.ll
which has a minor degradation dispite though the pre-legalized DAG is
improved.

Reviewers: rnk, mkuper, jonpa, hfinkel, uweigand

Reviewed By: rnk

Subscribers: sdardis, nemanjai, javed.absar, llvm-commits

Differential Revision: https://reviews.llvm.org/D33345

llvm-svn: 307546
24 files changed:
llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
llvm/test/CodeGen/AArch64/arm64-abi-varargs.ll
llvm/test/CodeGen/AArch64/arm64-abi_align.ll
llvm/test/CodeGen/AArch64/arm64-alloca-frame-pointer-offset.ll
llvm/test/CodeGen/AArch64/arm64-vext.ll
llvm/test/CodeGen/AArch64/dag-combine-invaraints.ll
llvm/test/CodeGen/AArch64/swifterror.ll
llvm/test/CodeGen/ARM/atomic-op.ll
llvm/test/CodeGen/MSP430/vararg.ll
llvm/test/CodeGen/Mips/dins.ll
llvm/test/CodeGen/X86/2011-10-19-widen_vselect.ll
llvm/test/CodeGen/X86/alias-static-alloca.ll [new file with mode: 0644]
llvm/test/CodeGen/X86/clobber-fi0.ll
llvm/test/CodeGen/X86/hipe-cc.ll
llvm/test/CodeGen/X86/hipe-cc64.ll
llvm/test/CodeGen/X86/legalize-shift-64.ll
llvm/test/CodeGen/X86/machine-outliner-debuginfo.ll
llvm/test/CodeGen/X86/machine-outliner.ll
llvm/test/CodeGen/X86/statepoint-invoke.ll
llvm/test/CodeGen/X86/statepoint-stack-usage.ll
llvm/test/CodeGen/X86/statepoint-vector.ll
llvm/test/CodeGen/X86/widen_arith-2.ll
llvm/test/CodeGen/X86/widen_cast-4.ll
llvm/test/CodeGen/XCore/varargs.ll