blk-wbt: Replace strlcpy with strscpy
authorAzeem Shaikh <azeemshaikh38@gmail.com>
Mon, 3 Jul 2023 17:21:59 +0000 (17:21 +0000)
committerJens Axboe <axboe@kernel.dk>
Mon, 17 Jul 2023 14:18:17 +0000 (08:18 -0600)
commit16291561e125ef50cb1875227fce9c1583f0de3c
treeb4ff133cacc575ef353531779cba8b0bd26ae50f
parent222f58ac68cd6f98a52faf9f26a219c996a5aa17
blk-wbt: Replace strlcpy with strscpy

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230703172159.3668349-3-azeemshaikh38@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
include/trace/events/wbt.h