drm/virtio: do NOT reuse resource ids
authorGerd Hoffmann <kraxel@redhat.com>
Fri, 8 Feb 2019 14:04:09 +0000 (15:04 +0100)
committerDave Airlie <airlied@redhat.com>
Mon, 11 Feb 2019 04:44:10 +0000 (14:44 +1000)
commit16065fcdd19ddb9e093192914ac863884f308766
tree29c369003e067cd02fd93ded26d66d4f1619787d
parentf4bc54b532a62d8bee421ca06adb6d1b3e7ffaa9
drm/virtio: do NOT reuse resource ids

Bisected guest kernel changes crashing qemu.  Landed at
"6c1cd97bda drm/virtio: fix resource id handling".  Looked again, and
noticed we where not only leaking *some* ids, but *all* ids.  The old
code never ever called virtio_gpu_resource_id_put().

So, commit 6c1cd97bda effectively makes the linux kernel starting
re-using IDs after releasing them, and apparently virglrenderer can't
deal with that.  Oops.

This patch puts a temporary stopgap into place for the 5.0 release.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190208140409.15280-1-kraxel@redhat.com
drivers/gpu/drm/virtio/virtgpu_object.c