python: Fix inequality comparisons
authorMathieu Bridon <bochecha@daitauha.fr>
Thu, 9 Aug 2018 08:27:18 +0000 (10:27 +0200)
committerDylan Baker <dylan@pnwbakers.com>
Fri, 10 Aug 2018 15:45:59 +0000 (08:45 -0700)
commit15ac05fd45afb0d85f1806a77fc9ec47f4949f01
treeb75de3b5f0d6f55a299acf1c310a5565958375b2
parente94095ec30462d4264c6d7c7dd4fbf8bc0d99c69
python: Fix inequality comparisons

On Python 3, executing `foo != bar` will first try to call
foo.__ne__(bar), and fallback on the opposite result of foo.__eq__(bar).

Python 2 does not do that.

As a result, those __eq__ methods were never called, when we were
testing for inequality.

Expliclty adding the __ne__ methods fixes this issue, in a way that is
compatible with both Python 2 and 3.

However, this means the __eq__ methods are now called when testing for
`foo != None`, so they need to be guarded correctly.

Signed-off-by: Mathieu Bridon <bochecha@daitauha.fr>
Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
src/amd/vulkan/vk_format_parse.py
src/gallium/auxiliary/util/u_format_parse.py
src/mesa/main/format_parser.py