projects / kernel / kernel-generic.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: be9164e) | patch
tcp: Overflow bug in Vegas
authorLachlan Andrew <lachlan.andrew@gmail.com>
Wed, 30 Apr 2008 08:04:03 +0000 (01:04 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 30 Apr 2008 08:04:03 +0000 (01:04 -0700)
commit159131149c2f56c1da5ae5e23ab9d5acef4916d1
tree7ad3fc498c27fd8dfdf4a1fcf506b1220919f715tree | snapshot
parentbe9164e769d57aa10b2bbe15d103edc041b9e7decommit | diff
tcp: Overflow bug in Vegas

From: Lachlan Andrew <lachlan.andrew@gmail.com>

There is an overflow bug in net/ipv4/tcp_vegas.c for large BDPs
(e.g. 400Mbit/s, 400ms).  The multiplication (old_wnd *
vegas->baseRTT) << V_PARAM_SHIFT overflows a u32.

[ Fix tcp_veno.c too, it has similar calculations. -DaveM ]

Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_vegas.c diff | blob | history
net/ipv4/tcp_veno.c diff | blob | history
Domain: System / Uncategorized;