drm/bridge: dw-hdmi: use safe format when first in bridge chain
authorNeil Armstrong <narmstrong@baylibre.com>
Fri, 4 Feb 2022 14:33:37 +0000 (15:33 +0100)
committerNeil Armstrong <narmstrong@baylibre.com>
Thu, 10 Feb 2022 15:36:53 +0000 (16:36 +0100)
commit1528038385c0a706aac9ac165eeb24044fef6825
tree02b056101904d3573e801e48eb7f80430d7de280
parentded74cafeea9311c1eaf6fccce963de2516145f7
drm/bridge: dw-hdmi: use safe format when first in bridge chain

When the dw-hdmi bridge is in first place of the bridge chain, this
means there is no way to select an input format of the dw-hdmi HW
component.

Since introduction of display-connector, negotiation was broken since
the dw-hdmi negotiation code only worked when the dw-hdmi bridge was
in last position of the bridge chain or behind another bridge also
supporting input & output format negotiation.

Commit 7cd70656d128 ("drm/bridge: display-connector: implement bus fmts callbacks")
was introduced to make negotiation work again by making display-connector
act as a pass-through concerning input & output format negotiation.

But in the case where the dw-hdmi is single in the bridge chain, for
example on Renesas SoCs, with the display-connector bridge the dw-hdmi
is no more single, breaking output format.

Reported-by: Biju Das <biju.das.jz@bp.renesas.com>
Bisected-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Tested-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Fixes: 6c3c719936da ("drm/bridge: synopsys: dw-hdmi: add bus format negociation")
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
[narmstrong: add proper fixes commit]
Reviewed-by: Robert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220204143337.89221-1-narmstrong@baylibre.com
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c