watchdog: don't run proc_watchdog_update if new value is same as old
authorJoshua Hunt <johunt@akamai.com>
Thu, 17 Mar 2016 21:17:23 +0000 (14:17 -0700)
committerSasha Levin <sasha.levin@oracle.com>
Mon, 18 Apr 2016 12:51:01 +0000 (08:51 -0400)
commit15207f3ca364563c590ba170ce40c1f90fd78268
treee7f181244f641f3b3628788f943e5a0cad0e3a31
parent3ec245e8591a183e276df89cd7f9e7a15645b9da
watchdog: don't run proc_watchdog_update if new value is same as old

[ Upstream commit a1ee1932aa6bea0bb074f5e3ced112664e4637ed ]

While working on a script to restore all sysctl params before a series of
tests I found that writing any value into the
/proc/sys/kernel/{nmi_watchdog,soft_watchdog,watchdog,watchdog_thresh}
causes them to call proc_watchdog_update().

  NMI watchdog: enabled on all CPUs, permanently consumes one hw-PMU counter.
  NMI watchdog: enabled on all CPUs, permanently consumes one hw-PMU counter.
  NMI watchdog: enabled on all CPUs, permanently consumes one hw-PMU counter.
  NMI watchdog: enabled on all CPUs, permanently consumes one hw-PMU counter.

There doesn't appear to be a reason for doing this work every time a write
occurs, so only do it when the values change.

Signed-off-by: Josh Hunt <johunt@akamai.com>
Acked-by: Don Zickus <dzickus@redhat.com>
Reviewed-by: Aaron Tomlin <atomlin@redhat.com>
Cc: Ulrich Obergfell <uobergfe@redhat.com>
Cc: <stable@vger.kernel.org> [4.1.x+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
kernel/watchdog.c