Allow 0-weight branches in BranchProbabilityInfo.
authorDiego Novillo <dnovillo@google.com>
Wed, 6 May 2015 17:55:11 +0000 (17:55 +0000)
committerDiego Novillo <dnovillo@google.com>
Wed, 6 May 2015 17:55:11 +0000 (17:55 +0000)
commit14f94de1ee6487f2f254709383258aaa095b4cfe
tree54ae768c7a48727f1f534f8e032e72aca57d5a22
parentc6317d55e4eb7e5c3aaa2309f2bcae36b41ba75e
Allow 0-weight branches in BranchProbabilityInfo.

Summary:
When computing branch weights in BPI, we used to disallow branches with
weight 0. This is a minor nuisance, because a branch with weight 0 is
different to "don't have information". In the context of
instrumentation, it may mean "never executed", in the context of
sampling, it means "never or seldom executed".

In allowing 0 weight branches, I ran into issues with the switch
expansion code in selection DAG. It is currently hardwired to not handle
branches with weight 0. To maintain the current behaviour, I changed it
to use 1 when it finds 0, but perhaps the algorithm needs changes to
tolerate branches with weight zero.

Reviewers: hansw

Subscribers: llvm-commits

Differential Revision: http://reviews.llvm.org/D9533

llvm-svn: 236617
llvm/lib/Analysis/BranchProbabilityInfo.cpp
llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
llvm/test/Transforms/SampleProfile/branch.ll
llvm/test/Transforms/SampleProfile/calls.ll
llvm/test/Transforms/SampleProfile/propagate.ll