[lldb] Make cursor index in CompletionRequest unsigned
authorRaphael Isemann <teemperor@gmail.com>
Mon, 23 Sep 2019 09:46:17 +0000 (09:46 +0000)
committerRaphael Isemann <teemperor@gmail.com>
Mon, 23 Sep 2019 09:46:17 +0000 (09:46 +0000)
commit14f6465c157b36c50ffe431463a9c94efda42b99
treecf3b97187f4a397a53a0a09ef8a033289e7123be
parent3e2fdbee80b0d14fcdb67cbb3072f43dbec66b38
[lldb] Make cursor index in CompletionRequest unsigned

The fact that index==-1 means "no arguments" is not obvious and only
used in one place from what I can tell. Also fixes several warnings
about using the cursor index as if it was a size_t when comparing.

Not fully NFC as we now also correctly update the partial argument list
when injecting the fake empty argument in the CompletionRequest
constructor.

llvm-svn: 372566
lldb/include/lldb/Utility/CompletionRequest.h
lldb/source/Commands/CommandObjectSettings.cpp
lldb/source/Interpreter/CommandInterpreter.cpp
lldb/source/Interpreter/Options.cpp
lldb/source/Utility/CompletionRequest.cpp
lldb/unittests/Utility/CompletionRequestTest.cpp