net/rose: Fix to not accept on connected socket
authorHyunwoo Kim <v4bel@theori.io>
Wed, 25 Jan 2023 10:59:44 +0000 (02:59 -0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 28 Jan 2023 08:19:57 +0000 (00:19 -0800)
commit14caefcf9837a2be765a566005ad82cd0d2a429f
tree6cf24163eefe3ca98e41293a1a6a756f85464d60
parentffffd2454a7a1bc9f7242b12c4cc0b05c12692b4
net/rose: Fix to not accept on connected socket

If you call listen() and accept() on an already connect()ed
rose socket, accept() can successfully connect.
This is because when the peer socket sends data to sendmsg,
the skb with its own sk stored in the connected socket's
sk->sk_receive_queue is connected, and rose_accept() dequeues
the skb waiting in the sk->sk_receive_queue.

This creates a child socket with the sk of the parent
rose socket, which can cause confusion.

Fix rose_listen() to return -EINVAL if the socket has
already been successfully connected, and add lock_sock
to prevent this issue.

Signed-off-by: Hyunwoo Kim <v4bel@theori.io>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Link: https://lore.kernel.org/r/20230125105944.GA133314@ubuntu
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/rose/af_rose.c