scsi: lpfc: Fix memory leak on lcb_context
authorColin Ian King <colin.king@canonical.com>
Wed, 18 Nov 2020 14:13:14 +0000 (14:13 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 20 Nov 2020 03:16:00 +0000 (22:16 -0500)
commit14c1dd9504112ffe86688ff0cd64149e16d36772
treeabaec277e14ca5d71da4ebcdf1e72eb22d2ab0a5
parent61795a5316ad8786fb4bb896198733188a60eab8
scsi: lpfc: Fix memory leak on lcb_context

Currently there is an error return path that neglects to free the
allocation for lcb_context.  Fix this by adding a new error free exit path
that kfree's lcb_context before returning.  Use this new kfree exit path in
another exit error path that also kfree's the same object, allowing a line
of code to be removed.

Link: https://lore.kernel.org/r/20201118141314.462471-1-colin.king@canonical.com
Fixes: 4430f7fd09ec ("scsi: lpfc: Rework locations of ndlp reference taking")
Reviewed-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Addresses-Coverity: ("Resource leak")
drivers/scsi/lpfc/lpfc_els.c