extcon: extcon-max14577: Fix potential work-queue cancellation race
authorMatti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Tue, 8 Jun 2021 10:09:55 +0000 (13:09 +0300)
committerHans de Goede <hdegoede@redhat.com>
Thu, 17 Jun 2021 11:21:44 +0000 (13:21 +0200)
commit14ad76825f00b1471a7ec2eff30528d21ee2772b
tree4374b1e87884ad3ace2df1f86c4ffb988b79e1e5
parent7a2c4cc537fa9f05fe90812e7d789b9faf7eb869
extcon: extcon-max14577: Fix potential work-queue cancellation race

The extcon IRQ schedules a work item. IRQ is requested using devm while
WQ is cancelld at remove(). This mixing of devm and manual unwinding has
potential case where the WQ has been emptied (.remove() was ran) but
devm unwinding of IRQ was not yet done. It is possible the IRQ is triggered
at this point scheduling new work item to the already flushed queue.

Use new devm_work_autocancel() to remove the remove() and to kill the bug.

Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Link: https://lore.kernel.org/r/ee8545f59ae3a93f0a70f640ecbd7e31cfadbcb9.1623146580.git.matti.vaittinen@fi.rohmeurope.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/extcon/extcon-max14577.c