PM: hibernate: Fix the exclusive get block device in test_resume mode
authorChen Yu <yu.c.chen@intel.com>
Wed, 6 Sep 2023 04:18:52 +0000 (12:18 +0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 12 Sep 2023 09:45:15 +0000 (11:45 +0200)
commit148b6f4cc3920e563094540fe1a12d00d3bbccae
tree34d6818c87ebde181ae5aa0c53b274c86d552bc7
parent40d84e198b0ae64df71ac0e70675b16900b90bde
PM: hibernate: Fix the exclusive get block device in test_resume mode

Commit 5904de0d735b ("PM: hibernate: Do not get block device exclusively
in test_resume mode") fixes a hibernation issue under test_resume mode.
That commit is supposed to open the block device in non-exclusive mode
when in test_resume. However the code does the opposite, which is against
its description.

In summary, the swap device is only opened exclusively by swsusp_check()
with its corresponding *close(), and must be in non test_resume mode.
This is to avoid the race condition that different processes scribble the
device at the same time. All the other cases should use non-exclusive mode.

Fix it by really disabling exclusive mode under test_resume.

Fixes: 5904de0d735b ("PM: hibernate: Do not get block device exclusively in test_resume mode")
Closes: https://lore.kernel.org/lkml/000000000000761f5f0603324129@google.com/
Reported-by: Pengfei Xu <pengfei.xu@intel.com>
Signed-off-by: Chen Yu <yu.c.chen@intel.com>
Tested-by: Chenzhou Feng <chenzhoux.feng@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
kernel/power/hibernate.c