nfs: fix potential credential leak in ff_layout_update_mirror_cred
authorJeff Layton <jlayton@poochiereds.net>
Wed, 24 Jun 2015 16:10:23 +0000 (12:10 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 Aug 2015 16:29:17 +0000 (09:29 -0700)
commit1488271989894c89ddac1fa6764edb89421c2160
tree312096a02ff527c1a13183c71fee8a5cc4a4e61c
parenta400ef50e78554c779742d45c6f7bfa4fa39d990
nfs: fix potential credential leak in ff_layout_update_mirror_cred

commit a24221dca1868101c9b4b5adde4a6a5b1a3a64a7 upstream.

If we have two tasks racing to update a mirror's credentials, then they
can end up leaking one (or more) sets of credentials. The first task
will set mirror->cred and then the second task will just overwrite it.

Use a cmpxchg to ensure that the creds are only set once. If we get to
the point where we would set mirror->cred and find that they're already
set, then we just release the creds that were just found.

Signed-off-by: Jeff Layton <jeff.layton@primarydata.com>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/nfs/flexfilelayout/flexfilelayoutdev.c