ima: detect changes to the backing overlay file
authorMimi Zohar <zohar@linux.ibm.com>
Wed, 18 Oct 2023 18:47:02 +0000 (14:47 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 28 Nov 2023 17:07:12 +0000 (17:07 +0000)
commit143f450c6cb28890da0002ebd1764cc804258de1
tree7840918d761aab1ea7f7caac8a9f6bd727ae80df
parent2c63b9d7f7c8558fdfdd4bdb77c04f1cf8eab221
ima: detect changes to the backing overlay file

commit b836c4d29f2744200b2af41e14bf50758dddc818 upstream.

Commit 18b44bc5a672 ("ovl: Always reevaluate the file signature for
IMA") forced signature re-evaulation on every file access.

Instead of always re-evaluating the file's integrity, detect a change
to the backing file, by comparing the cached file metadata with the
backing file's metadata.  Verifying just the i_version has not changed
is insufficient.  In addition save and compare the i_ino and s_dev
as well.

Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Tested-by: Eric Snowberg <eric.snowberg@oracle.com>
Tested-by: Raul E Rangel <rrangel@chromium.org>
Cc: stable@vger.kernel.org
Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/overlayfs/super.c
security/integrity/ima/ima_api.c
security/integrity/ima/ima_main.c
security/integrity/integrity.h