ALSA: fireface: fix configuration error for nominal sampling transfer frequency
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Sun, 10 May 2020 07:42:56 +0000 (16:42 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Jun 2020 14:40:27 +0000 (16:40 +0200)
commit13c18353c9853d707072e2a03b2d27ffbdb9190f
tree7537bfcebd72ea919686f032ecefdec77bb01b77
parent110d04acda5e27dcb86d27169777c5b848e2f701
ALSA: fireface: fix configuration error for nominal sampling transfer frequency

commit bbd6aac3ae15bef762af03bf62e35ace5c4292bd upstream.

128000 and 192000 are congruence modulo 32000, thus it's wrong to
distinguish them as multiple of 32000 and 48000 by modulo 32000 at
first.

Additionally, used condition statement to detect quadruple speed can
cause missing bit flag.

Furthermore, counter to ensure the configuration is wrong and it
causes false positive.

This commit fixes the above three bugs.

Cc: <stable@vger.kernel.org>
Fixes: 60aec494b389 ("ALSA: fireface: support allocate_resources operation in latter protocol")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20200510074301.116224-2-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/firewire/fireface/ff-protocol-latter.c