phy: hisilicon: Fix an out of bounds check in hisi_inno_phy_probe()
authorHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Fri, 21 Jul 2023 09:05:55 +0000 (02:05 -0700)
committerVinod Koul <vkoul@kernel.org>
Mon, 24 Jul 2023 10:53:37 +0000 (16:23 +0530)
commit13c088cf3657d70893d75cf116be937f1509cc0f
tree7df2800ceb49ca16f07d486b667fd661a04458bc
parent8932089b566c24ea19b57e37704c492678de1420
phy: hisilicon: Fix an out of bounds check in hisi_inno_phy_probe()

The size of array 'priv->ports[]' is INNO_PHY_PORT_NUM.

In the for loop, 'i' is used as the index for array 'priv->ports[]'
with a check (i > INNO_PHY_PORT_NUM) which indicates that
INNO_PHY_PORT_NUM is allowed value for 'i' in the same loop.

This > comparison needs to be changed to >=, otherwise it potentially leads
to an out of bounds write on the next iteration through the loop

Fixes: ba8b0ee81fbb ("phy: add inno-usb2-phy driver for hi3798cv200 SoC")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Link: https://lore.kernel.org/r/20230721090558.3588613-1-harshit.m.mogalapalli@oracle.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/hisilicon/phy-hisi-inno-usb2.c