Resubmit "Support embedding natvis files in PDBs."
authorZachary Turner <zturner@google.com>
Tue, 20 Mar 2018 17:06:39 +0000 (17:06 +0000)
committerZachary Turner <zturner@google.com>
Tue, 20 Mar 2018 17:06:39 +0000 (17:06 +0000)
commit132d7a134ffe0d0e0e4d62bb2b5b15075b009a0d
treeed5fcd7c0e1c5858b1ae0c4fe3faa282bbf64c69
parentec95e0eed9689ee7f03aca4825bddfedfd3b8d43
Resubmit "Support embedding natvis files in PDBs."

The issue causing this to fail in certain configurations
should be fixed.

It was due to the fact that DIA apparently expects there to be
a null string at ID 1 in the string table.  I'm not sure why this
is important but it seems to make a difference, so set it.

llvm-svn: 328002
31 files changed:
lld/COFF/Config.h
lld/COFF/Driver.cpp
lld/COFF/Options.td
lld/COFF/PDB.cpp
lld/test/COFF/Inputs/generic.yaml [new file with mode: 0644]
lld/test/COFF/Inputs/natvis-1.natvis [new file with mode: 0644]
lld/test/COFF/Inputs/natvis-2.natvis [new file with mode: 0644]
lld/test/COFF/Inputs/natvis-3.natvis [new file with mode: 0644]
lld/test/COFF/pdb-file-static.test
lld/test/COFF/pdb-natvis.test [new file with mode: 0644]
lld/test/lit.cfg.py
lld/test/lit.site.cfg.py.in
llvm/include/llvm/DebugInfo/CodeView/DebugStringTableSubsection.h
llvm/include/llvm/DebugInfo/PDB/DIA/DIAInjectedSource.h
llvm/include/llvm/DebugInfo/PDB/Native/HashTable.h
llvm/include/llvm/DebugInfo/PDB/Native/PDBFileBuilder.h
llvm/include/llvm/DebugInfo/PDB/Native/PDBStringTableBuilder.h
llvm/include/llvm/DebugInfo/PDB/Native/RawConstants.h
llvm/include/llvm/DebugInfo/PDB/Native/RawTypes.h
llvm/lib/DebugInfo/CodeView/DebugChecksumsSubsection.cpp
llvm/lib/DebugInfo/CodeView/DebugCrossImpSubsection.cpp
llvm/lib/DebugInfo/CodeView/DebugStringTableSubsection.cpp
llvm/lib/DebugInfo/PDB/DIA/DIAEnumInjectedSources.cpp
llvm/lib/DebugInfo/PDB/DIA/DIAInjectedSource.cpp
llvm/lib/DebugInfo/PDB/Native/InfoStreamBuilder.cpp
llvm/lib/DebugInfo/PDB/Native/PDBFileBuilder.cpp
llvm/lib/DebugInfo/PDB/Native/PDBStringTableBuilder.cpp
llvm/tools/llvm-pdbutil/DumpOutputStyle.cpp
llvm/tools/llvm-pdbutil/DumpOutputStyle.h
llvm/tools/llvm-pdbutil/llvm-pdbutil.cpp
llvm/tools/llvm-pdbutil/llvm-pdbutil.h