net: fec: fix regression on i.MX28 introduced by rx_copybreak support
authorLothar Waßmann <LW@KARO-electronics.de>
Fri, 7 Nov 2014 09:02:47 +0000 (10:02 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 7 Nov 2014 17:08:58 +0000 (12:08 -0500)
commit1310b544e5708ab5e4de46e9c70f54b9fd8350b2
tree955eea9a2ce48066fbb2fc56b4ffd0ea57a09b3d
parent1f5623106fe8151c98e78a4e241cccd0453abda7
net: fec: fix regression on i.MX28 introduced by rx_copybreak support

commit 1b7bde6d659d ("net: fec: implement rx_copybreak to improve rx performance")
introduced a regression for i.MX28. The swap_buffer() function doing
the endian conversion of the received data on i.MX28 may access memory
beyond the actual packet size in the DMA buffer. fec_enet_copybreak()
does not copy those bytes, so that the last bytes of a packet may be
filled with invalid data after swapping.
This will likely lead to checksum errors on received packets.
E.g. when trying to mount an NFS rootfs:
UDP: bad checksum. From 192.168.1.225:111 to 192.168.100.73:44662 ulen 36

Do the byte swapping and copying to the new skb in one go if
necessary.

Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
Tested-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/fec_main.c