riscv: Avoid enabling interrupts in die()
authorMattias Nissler <mnissler@rivosinc.com>
Wed, 15 Feb 2023 14:48:28 +0000 (14:48 +0000)
committerPalmer Dabbelt <palmer@rivosinc.com>
Wed, 22 Feb 2023 01:21:45 +0000 (17:21 -0800)
commit130aee3fd9981297ff9354e5d5609cd59aafbbea
treec0e1d627a94dc85d95cca4dcd4c0899e3bebeae0
parent416721ff05fddc58ca531b6f069de250301de6e5
riscv: Avoid enabling interrupts in die()

While working on something else, I noticed that the kernel would start
accepting interrupts again after crashing in an interrupt handler. Since
the kernel is already in inconsistent state, enabling interrupts is
dangerous and opens up risk of kernel state deteriorating further.
Interrupts do get enabled via what looks like an unintended side effect of
spin_unlock_irq, so switch to the more cautious
spin_lock_irqsave/spin_unlock_irqrestore instead.

Fixes: 76d2a0493a17 ("RISC-V: Init and Halt Code")
Signed-off-by: Mattias Nissler <mnissler@rivosinc.com>
Reviewed-by: Björn Töpel <bjorn@kernel.org>
Link: https://lore.kernel.org/r/20230215144828.3370316-1-mnissler@rivosinc.com
Cc: stable@vger.kernel.org
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
arch/riscv/kernel/traps.c