splice: always fsnotify_access(in), fsnotify_modify(out) on success
authorAhelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Mon, 3 Jul 2023 14:42:13 +0000 (16:42 +0200)
committerChristian Brauner <brauner@kernel.org>
Mon, 10 Jul 2023 12:36:11 +0000 (14:36 +0200)
commit12ee4b66af34f8e72f3b2fd93a946a955efe7c86
treefe5437f82cb470dce488406fa0b349185f84549a
parentba38980add7ffc9e674ada5b4ded4e7d14e76581
splice: always fsnotify_access(in), fsnotify_modify(out) on success

The current behaviour caused an asymmetry where some write APIs
(write, sendfile) would notify the written-to/read-from objects,
but splice wouldn't.

This affected userspace which uses inotify, most notably coreutils
tail -f, to monitor pipes.
If the pipe buffer had been filled by a splice-family function:
  * tail wouldn't know and thus wouldn't service the pipe, and
  * all writes to the pipe would block because it's full,
thus service was denied.
(For the particular case of tail -f this could be worked around
 with ---disable-inotify.)

Fixes: 983652c69199 ("splice: report related fsnotify events")
Link: https://lore.kernel.org/linux-fsdevel/jbyihkyk5dtaohdwjyivambb2gffyjs3dodpofafnkkunxq7bu@jngkdxx65pux/t/#u
Link: https://bugs.debian.org/1039488
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Acked-by: Jan Kara <jack@suse.cz>
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Message-Id: <604ec704d933e0e0121d9e107ce914512e045fad.1688393619.git.nabijaczleweli@nabijaczleweli.xyz>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/splice.c