[clang-tidy] Give readability-redundant-string-init a customizable list of string...
authorMitchell Balan <mitchell@stellarscience.com>
Fri, 15 Nov 2019 23:09:27 +0000 (18:09 -0500)
committerMitchell Balan <mitchell@stellarscience.com>
Fri, 15 Nov 2019 23:09:42 +0000 (18:09 -0500)
commit12d7500ba2417c7f299daa83a7812962f15632ec
tree23e661b068ecacba0b178f2268ecad8efac5c59d
parent06f3dabe4a2e85a32ade27c0769b6084c828a206
[clang-tidy] Give readability-redundant-string-init a customizable list of string types to fix

Summary:
This patch adds a feature requested in https://reviews.llvm.org/D69238 to enable `readability-redundant-string-init` to take a list of strings to apply the fix to rather than hard-coding `basic_string`. It adds a `StringNames` option of semicolon-delimited names of string classes to which to apply this fix. Tests ensure this works with test class out::TestString as well as std::string and std::wstring as before. It should be applicable to llvm::StringRef, QString, etc.

Note: This commit was previously reverted due to a failing unit test. That test has been fixed in this version.

Reviewers: MyDeveloperDay, aaron.ballman, hokein, alexfh, JonasToth, gribozavr2

Patch by: poelmanc

Subscribers: gribozavr2, xazax.hun, Eugene.Zelenko, cfe-commits

Tags: #clang-tools-extra, #clang

Differential Revision: https://reviews.llvm.org/D69548
clang-tools-extra/clang-tidy/readability/RedundantStringInitCheck.cpp
clang-tools-extra/clang-tidy/readability/RedundantStringInitCheck.h
clang-tools-extra/docs/ReleaseNotes.rst
clang-tools-extra/docs/clang-tidy/checks/readability-redundant-string-init.rst
clang-tools-extra/test/clang-tidy/checkers/readability-redundant-string-init.cpp