perf probe: Fix memory leakage when the probe point is not found
authorMasami Hiramatsu <mhiramat@kernel.org>
Fri, 10 Jul 2020 13:11:23 +0000 (22:11 +0900)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 17 Jul 2020 12:09:46 +0000 (09:09 -0300)
commit12d572e785b15bc764e956caaa8a4c846fd15694
treed0a2ec8157a386d7d24043cda48c4855bdd6770d
parent11fd3eb874e73ee8069bcfd54e3c16fa7ce56fe6
perf probe: Fix memory leakage when the probe point is not found

Fix the memory leakage in debuginfo__find_trace_events() when the probe
point is not found in the debuginfo. If there is no probe point found in
the debuginfo, debuginfo__find_probes() will NOT return -ENOENT, but 0.

Thus the caller of debuginfo__find_probes() must check the tf.ntevs and
release the allocated memory for the array of struct probe_trace_event.

The current code releases the memory only if the debuginfo__find_probes()
hits an error but not checks tf.ntevs. In the result, the memory allocated
on *tevs are not released if tf.ntevs == 0.

This fixes the memory leakage by checking tf.ntevs == 0 in addition to
ret < 0.

Fixes: ff741783506c ("perf probe: Introduce debuginfo to encapsulate dwarf information")
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
Reviewed-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: stable@vger.kernel.org
Link: http://lore.kernel.org/lkml/159438668346.62703.10887420400718492503.stgit@devnote2
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/probe-finder.c