[libc++] Don't trigger unsigned conversion warnings in std::advance
authorLouis Dionne <ldionne@apple.com>
Mon, 8 Jun 2020 20:16:01 +0000 (16:16 -0400)
committerLouis Dionne <ldionne@apple.com>
Tue, 16 Jun 2020 17:47:47 +0000 (13:47 -0400)
commit12b01ab7fa10939d67ac7cb2da1d3ca8a41b5fcd
treeb2a4c1583edf03fa94ece93c9013546a10680083
parent4676cf444ea2678660ee48279be99efde4bf60e9
[libc++] Don't trigger unsigned conversion warnings in std::advance

The Standard documents the signature of std::advance as

    template <class Iter, class Distance>
    constexpr void advance(Iter& i, Distance n);

Furthermore, it does not appear to put any restriction on what the type
of Distance should be. While it is understood that it should usually
be std::iterator_traits::difference_type, I couldn't find any wording
that mandates that. Similarly, I couldn't find wording that forces the
distance to be a signed type.

This patch changes std::advance to accept any type in the second argument,
which appears to be what the Standard mandates. We then coerce it to the
iterator's difference type, but that's an implementation detail.

Differential Revision: https://reviews.llvm.org/D81425
libcxx/include/iterator
libcxx/test/std/iterators/iterator.primitives/iterator.operations/advance.pass.cpp