Make __has_unique_object_representations reject empty union types.
authorEric Fiselier <eric@efcs.ca>
Fri, 2 Feb 2018 20:30:39 +0000 (20:30 +0000)
committerEric Fiselier <eric@efcs.ca>
Fri, 2 Feb 2018 20:30:39 +0000 (20:30 +0000)
commit12a9f344c6d541fbb3a9c6218b37772887b7df95
treef400680fdb3a95d7152cc48c041a055762cf203a
parentb8973efb3cbffdc1272cd7c896e988f0e9640c26
Make __has_unique_object_representations reject empty union types.

Summary:
Clang incorrectly reports empty unions as having a unique object representation. However, this is not correct since `sizeof(EmptyUnion) == 1` AKA it has 8 bits of padding. Therefore it should be treated the same as an empty struct and report `false`.

@erichkeane also suggested this fix should be merged into the 6.0 release branch, so the initial release of `__has_unique_object_representations` is as bug-free as possible.

Reviewers: erichkeane, rsmith, aaron.ballman, majnemer

Reviewed By: erichkeane

Subscribers: cfe-commits, erichkeane

Differential Revision: https://reviews.llvm.org/D42863

llvm-svn: 324134
clang/lib/AST/ASTContext.cpp
clang/test/SemaCXX/type-traits.cpp