ASoC: codecs: rt1316-sdw: simplify set_stream
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Fri, 24 Mar 2023 01:44:00 +0000 (09:44 +0800)
committerMark Brown <broonie@kernel.org>
Wed, 29 Mar 2023 14:03:03 +0000 (15:03 +0100)
commit1294d7d71f6abad6299a12cf6911f8e5622c7865
tree258feb4d64258bbcd2607dad4c07b0e593bfa371
parentce8ffc1bac7bee5015eb68faf214b39fcbd65d15
ASoC: codecs: rt1316-sdw: simplify set_stream

Using a dynamic allocation to store a single pointer is not very
efficient/useful.

Worse, the memory is released in the SoundWire stream.c file, but
still accessed in the DAI shutdown, leading to kmemleak reports.

And last the API requires the previous stream information to be
cleared when the argument is NULL.

Simplify the code to address all 3 problems.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20230324014408.1677505-6-yung-chuan.liao@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt1316-sdw.c
sound/soc/codecs/rt1316-sdw.h