usb: gadget: composite: prevent a memory leak when configuration bind fails
authorYongsul Oh <yongsul96.oh@samsung.com>
Tue, 20 Mar 2012 01:38:38 +0000 (10:38 +0900)
committerFelipe Balbi <balbi@ti.com>
Fri, 4 May 2012 12:53:06 +0000 (15:53 +0300)
commit124ef389256f71042ab5dedde98dee5e9999a635
tree1473efbd86a1e4c30c87dcd66b0bd9365daba493
parentc2484606a105e35a9bbbfafa41ee32683b82cf5a
usb: gadget: composite: prevent a memory leak when configuration bind fails

In some USB composite gadget drivers, the configuration's bind function called
by the usb_add_config() calls multiple bind config functions. (for example cdc2
configuration bind function in the cdc_do_config() of the cdc2.c has two
functionality bind config functions.
  - the ecm_bind_config() & the acm_bind_config())

In each functionality bind config function, new instance is allocated and
finally added by the usb_add_function().

So if an error occurred during the second functionality bind config (for
example an error occurred at the acm_bind_config() after succeeding of the
ecm_bind_function()), the instance created by the acm_bind_config() cannot be
freed creating a memory leak.

This patch fixes this issue.

Signed-off-by: Yongsul Oh <yongsul96.oh@samsung.com>
Acked-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/gadget/composite.c