fork: add kernel_clone_args flag to not dup/clone files
authorMike Christie <michael.christie@oracle.com>
Fri, 10 Mar 2023 22:03:27 +0000 (16:03 -0600)
committerChristian Brauner (Microsoft) <brauner@kernel.org>
Sun, 12 Mar 2023 09:54:43 +0000 (10:54 +0100)
commit11f3f500ec8a75c96087f3bed87aa2b1c5de7498
tree08d3834456a1139b1a6a3f059d13713bc8c268e2
parent54e6842d0775ba76db65cbe21311c3ca466e663d
fork: add kernel_clone_args flag to not dup/clone files

Each vhost device gets a thread that is used to perform IO and management
operations. Instead of a thread that is accessing a device, the thread is
part of the device, so when it creates a thread using a helper based on
copy_process we can't dup or clone the parent's files/FDS because it
would do an extra increment on ourself.

Later, when we do:

Qemu process exits:
        do_exit -> exit_files -> put_files_struct -> close_files

we would leak the device's resources because of that extra refcount
on the fd or file_struct.

This patch adds a no_files option so these worker threads can prevent
taking an extra refcount on themselves.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
Acked-by: Christian Brauner <brauner@kernel.org>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Christian Brauner (Microsoft) <brauner@kernel.org>
include/linux/sched/task.h
kernel/fork.c