net: lan78xx: Avoid unnecessary self assignment
authorNathan Chancellor <natechancellor@gmail.com>
Thu, 20 Sep 2018 22:48:30 +0000 (15:48 -0700)
committerJunghoon Kim <jhoon20.kim@samsung.com>
Tue, 11 Jun 2019 00:35:54 +0000 (09:35 +0900)
commit11c49e1f948875e4462c11fbcabe81e395677c18
tree0e97c23baa3b610c54c5f368523546fd174e92cd
parent2031d321ae9f4b50a0cad348d03b8ae2564f237f
net: lan78xx: Avoid unnecessary self assignment

Clang warns when a variable is assigned to itself.

drivers/net/usb/lan78xx.c:940:11: warning: explicitly assigning value of
variable of type 'u32' (aka 'unsigned int') to itself [-Wself-assign]
                        offset = offset;
                        ~~~~~~ ^ ~~~~~~
1 warning generated.

Reorder the if statement to acheive the same result and avoid a self
assignment warning.

Link: https://github.com/ClangBuiltLinux/linux/issues/129
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
[sw0312.kim: cherry-pick mainline commit 94e7c844990f to remove build warning with llvm/clang]
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
Change-Id: I18dc3e4145348830101d9474c38700565faf4761
drivers/net/usb/lan78xx.c