apparmor: fix reference count leak in aa_pivotroot()
authorXin Xiong <xiongx18@fudan.edu.cn>
Thu, 28 Apr 2022 03:39:08 +0000 (11:39 +0800)
committerJohn Johansen <john.johansen@canonical.com>
Sat, 9 Jul 2022 22:13:59 +0000 (15:13 -0700)
commit11c3627ec6b56c1525013f336f41b79a983b4d46
tree0f68d3c99a74ef6e88371d3663d8fa9f9595ac11
parentbab1f77fb815374e9d092a72d5a2abc7c943bca3
apparmor: fix reference count leak in aa_pivotroot()

The aa_pivotroot() function has a reference counting bug in a specific
path. When aa_replace_current_label() returns on success, the function
forgets to decrement the reference count of “target”, which is
increased earlier by build_pivotroot(), causing a reference leak.

Fix it by decreasing the refcount of “target” in that path.

Fixes: 2ea3ffb7782a ("apparmor: add mount mediation")
Co-developed-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Co-developed-by: Xin Tan <tanxin.ctf@gmail.com>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Signed-off-by: Xin Xiong <xiongx18@fudan.edu.cn>
Signed-off-by: John Johansen <john.johansen@canonical.com>
security/apparmor/mount.c