perf/x86/utils: Fix uninitialized var in get_branch_type()
authorStephane Eranian <eranian@google.com>
Wed, 28 Sep 2022 18:40:42 +0000 (11:40 -0700)
committerPeter Zijlstra <peterz@infradead.org>
Thu, 29 Sep 2022 10:20:56 +0000 (12:20 +0200)
commit117ceeb1f4f87331e45a77e71f18303d15ec882e
tree31299bdd4bd3ac6b5e79e78b1617315d68e57dc8
parentcfef80bad4cf79cdc964a53c98254dfa462be83f
perf/x86/utils: Fix uninitialized var in get_branch_type()

offset is passed as a pointer and on certain call path is not set by the
function. If the caller does not re-initialize offset between calls, value
could be inherited between calls. Prevent this by initializing offset on each
call.

This impacts the code in amd_pmu_lbr_filter() which does:

   for(i=0; ...) {
       ret = get_branch_type_fused(..., &offset);
       if (offset)
          lbr_entries[i].from += offset;
   }

Fixes: df3e9612f758 ("perf/x86: Make branch classifier fusion-aware")
Signed-off-by: Stephane Eranian <eranian@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Sandipan Das <sandipan.das@amd.com>
Link: https://lore.kernel.org/r/20220928184043.408364-2-eranian@google.com
arch/x86/events/utils.c