firmware: google: test spinlock on panic path to avoid lockups
authorGuilherme G. Piccoli <gpiccoli@igalia.com>
Fri, 9 Sep 2022 20:07:55 +0000 (17:07 -0300)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 3 Oct 2022 21:21:42 +0000 (14:21 -0700)
commit1179083ff07698b870da30a5aad34d44ed5dae10
tree3eae5963ffac319439e1bc7933277b3d71e1121a
parent5758478a3d3c42a78ee9ddc4b08db3e968a68058
firmware: google: test spinlock on panic path to avoid lockups

Currently the gsmi driver registers a panic notifier as well as reboot and
die notifiers.  The callbacks registered are called in atomic and very
limited context - for instance, panic disables preemption and local IRQs,
also all secondary CPUs (not executing the panic path) are shutdown.

With that said, taking a spinlock in this scenario is a dangerous
invitation for lockup scenarios.  So, fix that by checking if the spinlock
is free to acquire in the panic notifier callback - if not, bail-out and
avoid a potential hang.

Link: https://lkml.kernel.org/r/20220909200755.189679-1-gpiccoli@igalia.com
Fixes: 74c5b31c6618 ("driver: Google EFI SMI")
Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
Reviewed-by: Evan Green <evgreen@chromium.org>
Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: David Gow <davidgow@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Julius Werner <jwerner@chromium.org>
Cc: Petr Mladek <pmladek@suse.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/firmware/google/gsmi.c