objtool: Fix clang switch table edge case
authorJosh Poimboeuf <jpoimboe@redhat.com>
Tue, 18 Feb 2020 03:41:53 +0000 (21:41 -0600)
committerBorislav Petkov <bp@suse.de>
Fri, 21 Feb 2020 09:12:52 +0000 (10:12 +0100)
commit113d4bc9048336ba7c3d2ad972dbad4aef6e148a
tree2c0a8e6d52e3b29ae17f63241d81afbcf23866dd
parentdc4197236c20e761f2007c641afd193f81a00a74
objtool: Fix clang switch table edge case

Clang has the ability to create a switch table which is not a jump
table, but is rather a table of string pointers.  This confuses objtool,
because it sees the relocations for the string pointers and assumes
they're part of a jump table:

  drivers/ata/sata_dwc_460ex.o: warning: objtool: sata_dwc_bmdma_start_by_tag()+0x3a2: can't find switch jump table
  net/ceph/messenger.o: warning: objtool: ceph_con_workfn()+0x47c: can't find switch jump table

Make objtool's find_jump_table() smart enough to distinguish between a
switch jump table (which has relocations to text addresses in the same
function as the original instruction) and other anonymous rodata (which
may have relocations to elsewhere).

Reported-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Tested-by: Nick Desaulniers <ndesaulniers@google.com>
Tested-by: Nathan Chancellor <natechancellor@gmail.com>
Link: https://github.com/ClangBuiltLinux/linux/issues/485
Link: https://lkml.kernel.org/r/263f6aae46d33da0b86d7030ced878cb5cab1788.1581997059.git.jpoimboe@redhat.com
tools/objtool/check.c