f2fs: move f2fs_balance_fs from truncate to punch_hole
authorJason Hrycay <jason.hrycay@motorola.com>
Tue, 9 Apr 2013 01:16:44 +0000 (20:16 -0500)
committerJaegeuk Kim <jaegeuk.kim@samsung.com>
Tue, 9 Apr 2013 08:22:45 +0000 (17:22 +0900)
commit1127a3d448bcf4de338e60a7cc695d54c5767433
tree7b7dee3b1eedecd5d5d125f5a6e919fc2fb46d10
parent49952fa182a2e9b3f40b974278c5b1144f0c918b
f2fs: move f2fs_balance_fs from truncate to punch_hole

Move the f2fs_balance_fs out of the truncate_hole function and only
perform that in punch_hole use case.  The commit:

  ed60b1644e7f7e5dd67d21caf7e4425dff05dad0

intended to do this but moved it into truncate_hole to cover more
cases.  However, a deadlock scenario is possible when deleting an inode
entry under specific conditions:

 f2fs_delete_entry()
     mutex_lock_op(sbi, DENTRY_OPS);
     truncate_hole()
         f2fs_balance_fs()
             mutex_lock(&sbi->gc_mutex);
             f2fs_gc()
                 write_checkpoint()
                     block_operations()
                         mutex_lock_op(sbi, DENTRY_OPS);

Lets move it into the punch_hole case to cover the original intent of
avoiding it during fallocate's expand_inode_data case.

Change-Id: I29f8ea1056b0b88b70ba8652d901b6e8431bb27e
Signed-off-by: Jason Hrycay <jason.hrycay@motorola.com>
Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
fs/f2fs/file.c