io_uring: fix race in unified task_work running
authorJens Axboe <axboe@kernel.dk>
Mon, 26 Jul 2021 16:42:56 +0000 (10:42 -0600)
committerJens Axboe <axboe@kernel.dk>
Mon, 26 Jul 2021 16:42:56 +0000 (10:42 -0600)
commit110aa25c3ce417a44e35990cf8ed22383277933a
treed44e394878d2d3dbd3fd0aafa1555e0ff4c8034b
parent44eff40a32e8f5228ae041006352e32638ad2368
io_uring: fix race in unified task_work running

We use a bit to manage if we need to add the shared task_work, but
a list + lock for the pending work. Before aborting a current run
of the task_work we check if the list is empty, but we do so without
grabbing the lock that protects it. This can lead to races where
we think we have nothing left to run, where in practice we could be
racing with a task adding new work to the list. If we do hit that
race condition, we could be left with work items that need processing,
but the shared task_work is not active.

Ensure that we grab the lock before checking if the list is empty,
so we know if it's safe to exit the run or not.

Link: https://lore.kernel.org/io-uring/c6bd5987-e9ae-cd02-49d0-1b3ac1ef65b1@tnonline.net/
Cc: stable@vger.kernel.org # 5.11+
Reported-by: Forza <forza@tnonline.net>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io_uring.c