net: mv643xx_eth: Do not clobber PHY link outside of state machine
authorFlorian Fainelli <f.fainelli@gmail.com>
Mon, 6 Feb 2017 23:55:20 +0000 (15:55 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 7 Feb 2017 18:48:21 +0000 (13:48 -0500)
commit1105a2d3b36d1603043662d7f46c962b30ebca9e
treea5315d3102597ad85218a87838bd89c14bb70f22
parent501ec18757abdaba95440dbbd1d5df0611f813c4
net: mv643xx_eth: Do not clobber PHY link outside of state machine

Calling phy_read_status() means that we may call into
genphy_read_status() which in turn will use genphy_update_link() which
can make changes to phydev->link outside of the state machine's state
transitions. This is an invalid behavior that is now caught as of
811a919135b9 ("phy state machine: failsafe leave invalid RUNNING state")

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/mv643xx_eth.c