usb: gadget: move choice ... endchoice to legacy/Kconfig
authorMasahiro Yamada <masahiroy@kernel.org>
Wed, 11 Dec 2019 07:38:57 +0000 (16:38 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 17 Dec 2019 15:24:13 +0000 (16:24 +0100)
commit10e5e6c2496354f0afec82dba459339c421badbf
tree1c0d13cf9f5cf68139281460e064c2368a242630
parentfcc84698291203f6588598be417b3ac58d2561d3
usb: gadget: move choice ... endchoice to legacy/Kconfig

drivers/usb/gadget/Kconfig includes drivers/usb/gadget/legacy/Kconfig
inside the 'choice' block. The current Kconfig allows this, but I'd
like to discourage this usage.

People tend to mess up the structure without noticing that entire
drivers/usb/gadget/legacy/Kconfig is placed in the choice context.
In fact, legacy/Kconfig mixes up bool and tristate in the choice,
and creates nested choice, etc.

This commit does not change the behavior, but it will help people
notice how badly this Kconfig file is written.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Link: https://lore.kernel.org/r/20191211073857.16780-1-masahiroy@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/Kconfig
drivers/usb/gadget/legacy/Kconfig