udp: fix dst races with multicast early demux
authorEric Dumazet <edumazet@google.com>
Sat, 1 Aug 2015 10:14:33 +0000 (12:14 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 4 Aug 2015 05:16:50 +0000 (22:16 -0700)
commit10e2eb878f3ca07ac2f05fa5ca5e6c4c9174a27a
tree69bf946cc397f31aa7cbfc8d19c04b50d6f0fc76
parent2fc09962e24ace45154d0c16024f1eb15700f3e8
udp: fix dst races with multicast early demux

Multicast dst are not cached. They carry DST_NOCACHE.

As mentioned in commit f8864972126899 ("ipv4: fix dst race in
sk_dst_get()"), these dst need special care before caching them
into a socket.

Caching them is allowed only if their refcnt was not 0, ie we
must use atomic_inc_not_zero()

Also, we must use READ_ONCE() to fetch sk->sk_rx_dst, as mentioned
in commit d0c294c53a771 ("tcp: prevent fetching dst twice in early demux
code")

Fixes: 421b3885bf6d ("udp: ipv4: Add udp early demux")
Tested-by: Gregory Hoggarth <Gregory.Hoggarth@alliedtelesis.co.nz>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Gregory Hoggarth <Gregory.Hoggarth@alliedtelesis.co.nz>
Reported-by: Alex Gartrell <agartrell@fb.com>
Cc: Michal Kubeček <mkubecek@suse.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/udp.c