btrfs: fix compiler warning on SPARC/PA-RISC handling fscrypt_setup_filename
authorSweet Tea Dorminy <sweettea-kernel@dorminy.me>
Wed, 8 Mar 2023 15:58:36 +0000 (10:58 -0500)
committerDavid Sterba <dsterba@suse.com>
Wed, 15 Mar 2023 19:51:06 +0000 (20:51 +0100)
commit10a8857a1beaa015efba7d56e06243d484549fb6
treef1509f52eb549d5aeef219df88338617fd576d9b
parent1c3ab6dfa0692c3626580a508cf84e794201b357
btrfs: fix compiler warning on SPARC/PA-RISC handling fscrypt_setup_filename

Commit 1ec49744ba83 ("btrfs: turn on -Wmaybe-uninitialized") exposed
that on SPARC and PA-RISC, gcc is unaware that fscrypt_setup_filename()
only returns negative error values or 0. This ultimately results in a
maybe-uninitialized warning in btrfs_lookup_dentry().

Change to only return negative error values or 0 from
fscrypt_setup_filename() at the relevant call site, and assert that no
positive error codes are returned (which would have wider implications
involving other users).

Reported-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/all/481b19b5-83a0-4793-b4fd-194ad7b978c3@roeck-us.net/
Signed-off-by: Sweet Tea Dorminy <sweettea-kernel@dorminy.me>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/inode.c