bonding: fix race condition in bonding_store_slaves_active
authornikolay@redhat.com <nikolay@redhat.com>
Thu, 29 Nov 2012 01:37:59 +0000 (01:37 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 11 Jan 2013 17:06:26 +0000 (09:06 -0800)
commit1097b6a83df844d5145a1f9821300028857d8ca9
treede2710431a0a37c2e54f5d381dbfae68c35d0139
parent1789172140b7b61955b87b3070fb30da1a701d7c
bonding: fix race condition in bonding_store_slaves_active

[ Upstream commit e196c0e579902f42cf72414461fb034e5a1ffbf7 ]

Race between bonding_store_slaves_active() and slave manipulation
 functions. The bond_for_each_slave use in bonding_store_slaves_active()
 is not protected by any synchronization mechanism.
 NULL pointer dereference is easy to reach.
 Fixed by acquiring the bond->lock for the slave walk.

 v2: Make description text < 75 columns

Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/bonding/bond_sysfs.c