thermal: Validate new state in cur_state_store()
authorViresh Kumar <viresh.kumar@linaro.org>
Mon, 17 Oct 2022 10:03:01 +0000 (15:33 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 1 Feb 2023 07:27:15 +0000 (08:27 +0100)
commit108a6f91e2766a6d9142b1f2d90c07ac547eae7e
tree91587c8cf4e51440409509e5962cd939bce47d1f
parentbd0ea77edf46dcce86097f76bd4f768dc4b84c58
thermal: Validate new state in cur_state_store()

[ Upstream commit c408b3d1d9bbc7de5fb0304fea424ef2539da616 ]

In cur_state_store(), the new state of the cooling device is received
from user-space and is not validated by the thermal core but the same is
left for the individual drivers to take care of. Apart from duplicating
the code it leaves possibility for introducing bugs where a driver may
not do it right.

Lets make the thermal core check the new state itself and store the max
value in the cooling device structure.

Link: https://lore.kernel.org/all/Y0ltRJRjO7AkawvE@kili/
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Stable-dep-of: 6c54b7bc8a31 ("thermal: core: call put_device() only after device_register() fails")
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/thermal/gov_fair_share.c
drivers/thermal/thermal_core.c
drivers/thermal/thermal_sysfs.c
include/linux/thermal.h