[adt] Twine(nullptr) derefs the nullptr. Add a deleted Twine(std::nullptr_t)
authorDaniel Sanders <daniel_l_sanders@apple.com>
Fri, 18 Jan 2019 18:40:35 +0000 (18:40 +0000)
committerDaniel Sanders <daniel_l_sanders@apple.com>
Fri, 18 Jan 2019 18:40:35 +0000 (18:40 +0000)
commit1089e6e9e411710416632707d705858ef27d683c
tree66637ca71f2e6453c77d774540fa0a42ca530eb0
parentdc4e1547207fa31d80e423744b834291a69f6484
[adt] Twine(nullptr) derefs the nullptr. Add a deleted Twine(std::nullptr_t)

Summary:
nullptr can implicitly convert to Twine as Twine(nullptr) in which case it
resolves to Twine(const char *). This constructor derefs the pointer and
therefore doesn't work. Add a Twine(std::nullptr_t) = delete to make it a
compile time error.

It turns out that in-tree usage of Twine(nullptr) is confined to a single
private method in IRBuilder where foldConstant(... const Twine &Name = nullptr)
and this method is only ever called with an explicit Name argument as making it
a mandatory argument doesn't cause compile-time or run-time errors.

Reviewers: jyknight

Reviewed By: jyknight

Subscribers: dexonsmith, kristina, llvm-commits

Differential Revision: https://reviews.llvm.org/D56870

llvm-svn: 351572
llvm/include/llvm/ADT/Twine.h
llvm/include/llvm/IR/IRBuilder.h