bpf: Deref map in BPF_PROG_BIND_MAP when it's already used
authorStanislav Fomichev <sdf@google.com>
Sat, 3 Oct 2020 00:25:44 +0000 (17:25 -0700)
committerAlexei Starovoitov <ast@kernel.org>
Sat, 3 Oct 2020 02:21:25 +0000 (19:21 -0700)
commit1028ae4069991e26d1522e957939fb61d2da1d12
tree3515e99b6d9dafa966d02e423f092d6379d7998f
parentfb91db01c652ba9391f67c21db2d5260448b3efd
bpf: Deref map in BPF_PROG_BIND_MAP when it's already used

We are missing a deref for the case when we are doing BPF_PROG_BIND_MAP
on a map that's being already held by the program.
There is 'if (ret) bpf_map_put(map)' below which doesn't trigger
because we don't consider this an error.
Let's add missing bpf_map_put() for this specific condition.

Fixes: ef15314aa5de ("bpf: Add BPF_PROG_BIND_MAP syscall")
Reported-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: Stanislav Fomichev <sdf@google.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Andrii Nakryiko <andriin@fb.com>
Link: https://lore.kernel.org/bpf/20201003002544.3601440-1-sdf@google.com
kernel/bpf/syscall.c