drm/amd/display: fix issues with driver unload
authorHamza Mahfooz <hamza.mahfooz@amd.com>
Tue, 17 Jan 2023 20:12:49 +0000 (15:12 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 19 Jan 2023 03:46:33 +0000 (22:46 -0500)
commit0feeb4fd4c93efde2ac265d192392639fb4e253a
treec4d621891330039201d9323d7871cdb7df605cb1
parent09eb3ea3912644950eee3f8788796790ec0f022f
drm/amd/display: fix issues with driver unload

Currently, we run into a number of WARN()s when attempting to unload the
amdgpu driver (e.g. using "modprobe -r amdgpu"). These all stem from
calling drm_encoder_cleanup() too early. So, to fix this we can stop
calling drm_encoder_cleanup() from amdgpu_dm_fini() and instead have it
be called from amdgpu_dm_encoder_destroy(). Also, we don't need to free
in amdgpu_dm_encoder_destroy() since mst_encoders[] isn't explicitly
allocated by the slab allocator.

Fixes: f74367e492ba ("drm/amdgpu/display: create fake mst encoders ahead of time (v4)")
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c