scsi: mpt3sas: Stop fw fault watchdog work item during system shutdown
authorDavid Jeffery <djeffery@redhat.com>
Fri, 22 Jul 2022 14:24:48 +0000 (10:24 -0400)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 27 Jul 2022 01:40:43 +0000 (21:40 -0400)
commit0fde22c5420ed258ee538a760291c2f3935f6a01
tree1935d290ed44b0740a68e333d608b102b8227029
parent355bf2e036c954317ddc4a9618b4f7e38ea5a970
scsi: mpt3sas: Stop fw fault watchdog work item during system shutdown

During system shutdown or reboot, mpt3sas will reset the firmware back to
ready state. However, the driver leaves running a watchdog work item
intended to keep the firmware in operational state. This causes a second,
unneeded reset on shutdown and moves the firmware back to operational
instead of in ready state as intended. And if the mpt3sas_fwfault_debug
module parameter is set, this extra reset also panics the system.

mpt3sas's scsih_shutdown needs to stop the watchdog before resetting the
firmware back to ready state.

Link: https://lore.kernel.org/r/20220722142448.6289-1-djeffery@redhat.com
Fixes: fae21608c31c ("scsi: mpt3sas: Transition IOC to Ready state during shutdown")
Tested-by: Laurence Oberman <loberman@redhat.com>
Acked-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Signed-off-by: David Jeffery <djeffery@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/mpt3sas/mpt3sas_scsih.c