ethtool: allow non-netadmin to query settings
authorstephen hemminger <shemminger@vyatta.com>
Mon, 23 Aug 2010 10:24:18 +0000 (10:24 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 24 Aug 2010 03:43:16 +0000 (20:43 -0700)
commit0fdc100bdc4b7ab61ed632962c76dfe539047296
tree354e79b15b101a2ace627ce08779e4ef40c1e477
parentafdcba371f9748ac91608bb6c57f170aab7085b4
ethtool: allow non-netadmin to query settings

The SNMP daemon uses ethtool to determine the speed of
network interfaces. This fails on Debian (and probably elsewhere)
because for security SNMP daemon runs as non-root user (snmp).

Note: A similar patch was rejected previously because of a concern about
the possibility that on some hardware querying the ethtool settings
requires access to the PHY and could slow the machine down.  But the
security risk of requiring SNMP daemon (and related services)
to run as root far out weighs the risk of denial-of-service.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/ethtool.c