HID: hid-uclogic-params: Invalid parameter check in uclogic_params_frame_init_v1_butt...
authorJosé Expósito <jose.exposito89@gmail.com>
Wed, 5 Jan 2022 17:29:15 +0000 (18:29 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jan 2022 10:03:55 +0000 (11:03 +0100)
commit0fc97f944245de471cbabf637fd84036939e009a
treefef5503da5d6cc110448bd1631f61fe4b716992f
parentfc8a47ed624bd29b0ae91fbd96019274c87870cc
HID: hid-uclogic-params: Invalid parameter check in uclogic_params_frame_init_v1_buttonpad

[ Upstream commit aa320fdbbbb482c19100f51461bd0069753ce3d7 ]

The function performs a check on the hdev input parameters, however, it
is used before the check.

Initialize the udev variable after the sanity check to avoid a
possible NULL pointer dereference.

Fixes: 9614219e9310e ("HID: uclogic: Extract tablet parameter discovery into a module")
Addresses-Coverity-ID: 1443763 ("Null pointer dereference")
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/hid/hid-uclogic-params.c