KVM: arm64: Document why pause cannot be turned into a flag
authorMarc Zyngier <maz@kernel.org>
Sat, 28 May 2022 11:38:28 +0000 (12:38 +0100)
committerMarc Zyngier <maz@kernel.org>
Wed, 29 Jun 2022 09:23:51 +0000 (10:23 +0100)
commit0fa4a3137e943cd6acab386ff26cd8d5e94e9559
tree83a0be5e207d7e4fd8603769adc3c20a80be0647
parent54ddda919c4bc37c113727034619c4e15c184334
KVM: arm64: Document why pause cannot be turned into a flag

It would be tempting to turn the 'pause' state into a flag.

However, this cannot easily be done as it is updated out of context,
while all the flags expect to only be updated from the vcpu thread.
Turning it into a flag would require to make all flag updates
atomic, which isn't necessary desireable.

Document this, and take this opportunity to move the field next
to the flag sets, filling a hole in the vcpu structure.

Reviewed-by: Fuad Tabba <tabba@google.com>
Reviewed-by: Reiji Watanabe <reijiw@google.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
arch/arm64/include/asm/kvm_host.h