drm/rockchip: Fix suspend crash when drm is not bound
authorJeffy Chen <jeffy.chen@rock-chips.com>
Wed, 9 Aug 2017 10:41:03 +0000 (18:41 +0800)
committerSean Paul <seanpaul@chromium.org>
Wed, 9 Aug 2017 17:59:25 +0000 (13:59 -0400)
commit0fa375e6bc9023211eead30a6a79963c45a563da
tree77a368c8fefb162057a01df8e7453f5594b5505d
parent80c471ea040ad9006ebff6d64221a04e8fa1b7f6
drm/rockchip: Fix suspend crash when drm is not bound

Currently we are allocating drm_device in rockchip_drm_bind, so if the
suspend/resume code access it when drm is not bound, we would hit this
crash:

[  253.402836] Unable to handle kernel NULL pointer dereference at virtual address 00000028
[  253.402837] pgd = ffffffc06c9b0000
[  253.402841] [00000028] *pgd=0000000000000000, *pud=0000000000000000
[  253.402844] Internal error: Oops: 96000005 [#1] PREEMPT SMP
[  253.402859] Modules linked in: btusb btrtl btbcm btintel bluetooth ath10k_pci ath10k_core ar10k_ath ar10k_mac80211 cfg80211 ip6table_filter asix usbnet mii
[  253.402864] CPU: 4 PID: 1331 Comm: cat Not tainted 4.4.70 #15
[  253.402865] Hardware name: Google Scarlet (DT)
[  253.402867] task: ffffffc076c0ce00 ti: ffffffc06c2c8000 task.ti: ffffffc06c2c8000
[  253.402871] PC is at rockchip_drm_sys_suspend+0x20/0x5c

Add sanity checks to prevent that.

Reported-by: Brian Norris <briannorris@chromium.com>
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.kernel.org/patch/9890297/
drivers/gpu/drm/rockchip/rockchip_drm_drv.c