scsi: target: pscsi: Fix possible null-pointer dereference in pscsi_complete_cmd()
authorTuo Li <islituo@gmail.com>
Tue, 10 Aug 2021 04:04:13 +0000 (21:04 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 18 Aug 2021 02:28:39 +0000 (22:28 -0400)
commit0f99792c01d1d6d35b86e850e9ccadd98d6f3e0c
treeef16403ef5ac2463cc0eafcd349fb5dc2ba4854c
parent4c7b6ea336c1e415fc002c756449835de768914c
scsi: target: pscsi: Fix possible null-pointer dereference in pscsi_complete_cmd()

The return value of transport_kmap_data_sg() is assigned to the variable
buf:

  buf = transport_kmap_data_sg(cmd);

And then it is checked:

  if (!buf) {

This indicates that buf can be NULL. However, it is dereferenced in the
following statements:

  if (!(buf[3] & 0x80))
    buf[3] |= 0x80;
  if (!(buf[2] & 0x80))
    buf[2] |= 0x80;

To fix these possible null-pointer dereferences, dereference buf and call
transport_kunmap_data_sg() only when buf is not NULL.

Link: https://lore.kernel.org/r/20210810040414.248167-1-islituo@gmail.com
Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Reviewed-by: Bodo Stroesser <bostroesser@gmail.com>
Signed-off-by: Tuo Li <islituo@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/target/target_core_pscsi.c